search

backdrop-contrib / backup_migrate

Port of the Drupal backup_migrate module to Backdrop
GNU General Public License v2.0
7 stars 14 forks source link

[UX] Operations should be converted to drop-buttons #39

Closed jenlampton closed 1 year ago

jenlampton commented 6 years ago

The "Operations" column on the right hand side of the schedules page contains three links, edit, delete, and export, and the wrapping of text in that column makes the links hard to scan. Can we convert these into a drop-button instead? That would be consistent with the rest of Backdrop's admin UI.

screen shot 2018-03-30 at 3 09 03 pm

The same is true for the settings page:

screen shot 2018-03-30 at 3 16 11 pm
quackers8me commented 6 years ago

I took a look and I think this task is beyond my kin. It looks like the Operations links are generated dynamically from BAM's crud.inc but I'm not clear on how you could wrap that in the drop-button UI? I could not find how this UI is called in the admin. The only reference in the API is: https://api.backdropcms.org/api/backdrop/core%21includes%21theme.inc/function/theme_dropbutton_wrapper/1 but that function is never called in core modules.

jenlampton commented 6 years ago

but that function is never called in core modules.

Yeah, it's a little crazy for sure. A theme wrapper is attached to a render array rather than being called directly, so it can be hard to find examples. I'll see if I can file a PR for it.

argiepiano commented 1 year ago

@jenlampton, here's a PR: #90. Can you please test?

argiepiano commented 1 year ago

Reopening while people test this.

argiepiano commented 1 year ago

Closing now that this PR is included in version 1-x.1.0.23