search

backdrop-contrib / backup_migrate

Port of the Drupal backup_migrate module to Backdrop
GNU General Public License v2.0
7 stars 14 forks source link

remove nodesquirrel #53

Closed herbdool closed 4 years ago

herbdool commented 4 years ago

Addresses https://github.com/backdrop-contrib/backup_migrate/issues/50

jenlampton commented 4 years ago

I'm getting the following errors on update:

Warning: Invalid argument supplied for foreach() in backup_migrate_item->decode_db_row() (line 544 of /backdrop/modules/contrib/backup_migrate/includes/crud.inc).
Notice: Undefined property: backup_migrate_schedule::$destination_id in backup_migrate_update_1007() (line 518 of /backdrop/modules/contrib/backup_migrate/backup_migrate.install).
Notice: Undefined property: backup_migrate_schedule::$copy_destination_id in backup_migrate_update_1007() (line 540 of /backdrop/modules/contrib/backup_m

I think I remember this from the d.o issue, once the NodeSquirrel service is removed, the schedules that once used it become problematic... maybe?

herbdool commented 4 years ago

@jenlampton should we try fix those warnings before trying to get this merged? Not sure of best approach. Delete those schedules or put a message for people to fix them?

jenlampton commented 4 years ago

Everything works fine for me, even with the warnings. We can merge this first and add a follow up to address the warnings.

On Mon, Mar 23, 2020, 7:13 AM Herb notifications@github.com wrote:

@jenlampton https://github.com/jenlampton should we try fix those warnings before trying to get this merged? Not sure of best approach. Delete those schedules or put a message for people to fix them?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/backdrop-contrib/backup_migrate/pull/53#issuecomment-602620971, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADBER57MP46CN6AEJLYKVTRI5VBTANCNFSM4JSK4EUQ .