search

backdrop-contrib / backup_migrate

Port of the Drupal backup_migrate module to Backdrop
GNU General Public License v2.0
7 stars 14 forks source link

Use of DRUPAL_ROOT #6

Closed Graham-72 closed 9 years ago

Graham-72 commented 9 years ago

At line 506 in backup_migrate.module should it not be BACKDROP_ROOT ?

quackers8me commented 9 years ago

Hi @Graham-72, Thanks for catching that and I found some other Drupal references and hooks that could be replaced. Also merged in changes from recent Drupal module update.

Graham-72 commented 9 years ago

:+1: Thanks for porting this module. It would be good now to have it as a formal release so that it is recognised by update.

quackers8me commented 9 years ago

I wasn't aware of that and have now created a release. Thanks for pointing that out.

Graham-72 commented 9 years ago

And the system needs a line added to the .info file giving the type of the project i.e. type = module

I got caught out by this one when I first created a release.

quackers8me commented 9 years ago

Thanks again, also caught that my merge wasn't complete.

Graham-72 commented 9 years ago

I have found a couple more DRUPAL_ROOTs in includes/destinations.file.inc

quackers8me commented 9 years ago

Thank-you. Cleaned up now.