Make subsite registration and login optional

klonos commented 7 years ago

Respective d.org issue: https://www.drupal.org/node/2659992

PR by @serundeputy https://github.com/backdrop-contrib/bakery/pull/7

serundeputy commented 7 years ago

I started on this. Here is the patch to port from D7. https://gist.github.com/serundeputy/49310f7b51fde4b8d02ad89b342a0824 re: https://github.com/backdrop-ops/forum.backdropcms.org/issues/21

serundeputy commented 7 years ago

@jenlampton this applies the changes from the drupal queue (https://gist.github.com/serundeputy/49310f7b51fde4b8d02ad89b342a0824)

I can not think of a great/easy way to test this. Perhaps apply this patch (https://patch-diff.githubusercontent.com/raw/backdrop-contrib/bakery/pull/7.patch) to a test branch for forum and/or localize and test there.

Unless we have a staging server in which case we could test there.

jenlampton commented 7 years ago

Sorry for the delay guys, and thanks @serundeputy for picking up my slack! Last week was a doozy for me... I launched two new backdrop sites! staging.bollier.org and kvmrx.org (and I have a third on the way) but will get to this as soon as I can.

jenlampton commented 7 years ago

@serundeputy okay, patch applied to forum site.

jenlampton commented 7 years ago

@serundeputy the patch at https://gist.githubusercontent.com/serundeputy/49310f7b51fde4b8d02ad89b342a0824/raw/52165fe3222b2bb31f3e3fa9a3dc7b158ac30265/2659992-no-subsite-registration-login.patch applied to localize.

jenlampton commented 7 years ago

one error when running update.php on the forum site: Notice: Use of undefined constant is_master - assumed 'is_master' in bakery_menu() (line 22 of bakery/bakery.module).

jenlampton commented 7 years ago

Testing on the forum site, here's what I've found with subsite_login set to 1.

When logged OUT of backdropcms.org:

logging in as a "normal" user works seamlessly, redirected from forum -> borg -> forum (and logged in) 👍
logging out of one site, logs me out of all sites 👍
logging in as a "developer" (which is supposed to bypass bakery, and login using credentials stored in the local DB) fails. Login form reloads, I'm not logged in 👎 no messaging explaining what happened 👎

When logged IN to backdropcms.org:

attempting to log in as both a "normal" user and a "developer" fails in the same way, I get an access denied message on backdropcms.org 👎 no redirect back to the forum site 👎

Here's what I've found with subsite_login set to 0:

The user/login form still appears on the forum site 👎
submitting the form redirects me to the login form on the borg site 👎
logging on on the main site does not redirect me to the forum site 👎
manually returning to the forum site, I am not logged in 👎

backdrop-contrib / bakery

Make subsite registration and login optional #6