Closed yorkshire-pudding closed 2 years ago
@indigoxela - would you be happy to do a quick code review on this and then I'll merge it?
How can I trigger the warning for $delimiter_...
? I don't get those.
I only get the ones you posted in the issue description.
@indigoxela - I don't think you do as these are passed by other functions. I think someone could write an add-on that forgets to specify delimiter so I simply cast them all as string; for that function, they all should be string, so I didn't see any harm in doing them all.
@yorkshire-pudding ah, got it!
I can confirm that the annoying deprecated warnings are gone on php8.1 after applying the patch. :+1:
In a PHP 8.1 environment run
bee status
orbee status --show-password
PR to follow