search

backdrop-contrib / bee

:bee: Bee is a command line utility for Backdrop CMS. It includes commands that allow developers to interact with Backdrop sites.
GNU General Public License v2.0
16 stars 21 forks source link

PHPCS test is using an old tag #320

Closed yorkshire-pudding closed 1 year ago

yorkshire-pudding commented 1 year ago

I noticed that the phpcs workflow test was not picking up some issues that I am seeing locally with the latest version of the Backdrop phpcs standard. I tracked this down to the fact that is uses a tag 1.0.0.-beta1 from 2022. There are no newer tags.

It probably makes sense to just use the main branch so we don't need to keep track.

yorkshire-pudding commented 1 year ago

Fixed with commit 61010bc2319351158e1247bed373f22f2b15f7b3

indigoxela commented 1 year ago

How about asking to create a new tag? :wink:

Using tags has the advantage, that you always have a defined version in use. Otherwise things might change over night, and you don't know what happened.

yorkshire-pudding commented 1 year ago

That is an option, but I checked and saw there was just one tag over a year ago, so I didn't think they were being actively used. Perhaps a question for the phpcs repo but how do you feel about creating new tags after a merge?

indigoxela commented 1 year ago

Perhaps a question for the phpcs repo but how do you feel about creating new tags after a merge?

That might make sense. :thinking: Actually, your contribution was the first one easy to merge. A new tag exists now, BTW. :wink:

yorkshire-pudding commented 1 year ago

A new tag exists now, BTW.

Thanks - updated with that tag - 843f9f2804b8c8f651cf52efa405f4ed48e84ab9