backdrop-contrib / bootstrap_icons

Provides the Bootstrap Icons library of over 1500 icons as SVGs, SVG sprites, or web fonts.
GNU General Public License v2.0
1 stars 2 forks source link

Expose icons to core icon API #3

Open laryn opened 4 months ago

laryn commented 4 months ago

I threw this together while testing Icon Browser. I now see a module with this exact name already exists in contrib, maintained by you. If you think it's worth pulling the minor amount of code required to add this to your module, please feel free! I guess it would probably mean adding an option in your module not to embed the css and simply provide the icons to the core icon API?

I'll prepare a PR from the work referenced above for your review.

laryn commented 4 months ago

@bugfolder I'm second guessing whether the dependency is needed now -- that hook would just never be called on an older version of Backdrop, right?

bugfolder commented 4 months ago

that hook would just never be called on an older version of Backdrop, right?

"that hook" = hook_icon_info(), right? Yes, older versions wouldn't call it, so you don't need the added system version dependency, and in fact we shouldn't require it unless we absolutely have to, so that people on older versions of Backdrop (for whatever reason) could still upgrade the contrib module (if, for example, there's a bugfix release).

laryn commented 4 months ago

Removed.