search

backdrop-contrib / ckeditor

NOW IN BACKDROP CORE 🎉 Rich text editor integration using the CKeditor library.
GNU General Public License v2.0
0 stars 0 forks source link

Ready for official release? #6

Closed Graham-72 closed 9 years ago

Graham-72 commented 9 years ago

@quicksketch is it OK if I make an official release of this? I think it would be good to have this ready for Backdrop 1.1.x

quicksketch commented 9 years ago

Hi @Graham-72! Yes that would be great. The recent addition of Token module (and soon to be Pathauto) has given us a mechanism to move a module into core and disable the contrib version, however it will probably need to be elaborated to support replacing a module with the same name. But I think it would a good idea to make this publicly available asap to the existing users. We'll solve the problem for core when we get to it.

serundeputy commented 9 years ago

:+1:

klonos commented 9 years ago

First release was created. Please add type=module in the .info though.

Graham-72 commented 9 years ago

Type=module now added

klonos commented 9 years ago

Thanx @Graham-72 :+1:

Graham-72 commented 9 years ago

After resolving the below errors, create another release to try packaging again.

@klonos When I create another release should I give it a new number eg. 1.x-1.16.1

klonos commented 9 years ago

If the only change that you made is the type=module, then I believe you can get away with not incrementing release number.

Graham-72 commented 9 years ago

@klonos Thanks for the reply. To tidy things up and avoid the 'PACKAGING_ERROR_LOG.txt' (see below) I think perhaps I should try incrementing the version and release number and see what happens. releases backdrop-contrib-ckeditor 2015-05-04 20-26-12

Graham-72 commented 9 years ago

I have now produced release 1.x-1.16.1 as, hopefully, a tidy version.

klonos commented 9 years ago

No packaging error log. Good news! :wink:

quicksketch commented 9 years ago

Nice one @Graham-72!