search

backdrop-contrib / ckeditor_accordion

Provides the accordion plugin for CKEditor
GNU General Public License v2.0
0 stars 3 forks source link

Unable to add/remove tabs #4

Closed herbdool closed 1 year ago

herbdool commented 1 year ago

I can insert an accordion but it's only two tabs. In the plugin code I see that it's supposed to add a context menu to add tabs before or after, but for me at least these are not showing.

indigoxela commented 1 year ago

Wow, how can this ever have worked?

@herbdool a PR is available for testing. Funny enough, the fix is a one-liner to simply load the missing plugin-dependency.

herbdool commented 1 year ago

Aha! Thanks @indigoxela!

I was testing your PR out for awhile and I thought it still wasn't working. Until I realized that I needed to use the other mouse button to see the context menu. This will do!

I noticed there's no official maintainer. Would you be willing to be listed as the maintainer even if it's just for merging on bug fix PRs that other people make? Otherwise, there'd be no one to make a release when needed.

indigoxela commented 1 year ago

Until I realized that I needed to use the other mouse button to see the context menu

Yes, this is now (again) as it also works in the Drupal version. Maybe not ideal UX, but functional.

I noticed there's no official maintainer.

As noted in the chat, I've never used that module, only ported it for someone else (and silently hoped, someone takes over maintenance - which, of course, never happened). It probably makes sense to make me officially maintainer. :wink:

herbdool commented 1 year ago

Thanks @indigoxela. At least it's a fairly simple module. Now that it's fully working shouldn't need much attention. And it's probably ready for an official release. I've tested it a bunch and I haven't found any other problems.