search

backdrop-contrib / ckeditor_accordion

Provides the accordion plugin for CKEditor
GNU General Public License v2.0
0 stars 3 forks source link

ckeditor_accordion for ckeditor 5 #9

Open Egarbeil opened 10 months ago

Egarbeil commented 10 months ago

Create fork for ckeditor 5 - ckeditor_accordion works on 4 but not 5, so we're stuck with 4 until it is updated. The icons are there, but don't do anything on 5.

indigoxela commented 10 months ago

@Egarbeil bad news here. I'm not planning any updates for this module. See the status "Seeking new maintainer".

Personally, I never used this editor plugin, just ported it. And the complete rewrite for CKEditor 5 is too much effort for me.

So, if you want to take over maintainership, or know anyone who will, just go for it.

herbdool commented 10 months ago

I'm looking into the effort - doesn't look easy, but will need to talk with the client. The other thing we're considering is TinyMCE which has an accordion-like style by using the HTML tag <details>. It's not an exact replacement but it may be good enough for the client that's using this module.

Egarbeil commented 10 months ago

My clients definitely need it, but I am swamped. I have a lot scheduled before I even look at tackling this.

Be well and stay safe,

Elisabeth Garbeil, MBA Brainwrap LLC "Being on the web doesn't have to make your head hurt." www.brainwrap.com (810) 560-7181 @.***

On Jan 25, 2024, at 3:27 PM, Herb @.***> wrote:

I'm looking into the effort - doesn't look easy, but will need to talk with the client. The other thing we're considering is TinyMCE which has an accordion-like style by using the HTML tag

. It's not an exact replacement but it may be good enough for the client that's using this module.

— Reply to this email directly, view it on GitHub https://github.com/backdrop-contrib/ckeditor_accordion/issues/9#issuecomment-1910947602, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ4HZVSGJSL3JET5WZ3KNJTYQK52NAVCNFSM6AAAAABB5IETTCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJQHE2DONRQGI. You are receiving this because you were mentioned.

quicksketch commented 7 months ago

I'm taking a look at this as part of Backdrop Live, April 4-5, 2024. It's pretty complicated but I think I'll at least make a start.

Egarbeil commented 7 months ago

Thanks! I haven’t had a chance to start on it. I’m swamped till the middle of the summer. I’d be interested in learning how to rewrite for 4 to 5, because there are a number of other ckeditor plugins (like indent) that I’d like to work on or have updated.

Be well and stay safe,

Elisabeth Garbeil, MBA Brainwrap LLC "Being on the web doesn't have to make your head hurt." www.brainwrap.com (810) 560-7181 @.***

On Apr 4, 2024, at 10:21 PM, Nate Lampton @.***> wrote:

I'm taking a look at this as part of Backdrop Live, April 4-5, 2024. It's pretty complicated but I think I'll at least make a start.

— Reply to this email directly, view it on GitHub https://github.com/backdrop-contrib/ckeditor_accordion/issues/9#issuecomment-2038640206, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ4HZVXKA4GOPKYXCYVAOL3Y3YDEBAVCNFSM6AAAAABB5IETTCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZYGY2DAMRQGY. You are receiving this because you were mentioned.

indigoxela commented 7 months ago

@quicksketch many thanks for reviving that issue.

Actually, I think it can make sense to just add the CKE5 plugin as additional option, without dropping CKE4 support. So it's easier for people to switch. And possibly the ckeditor or ckeditor5 modules don't have to be a hard module dependency.

quicksketch commented 7 months ago

@indigoxela That's a novel idea! You're right, both could be supported at the same time, though I'm not sure if future changes we'd want to need to continue to add functionality to CKE4.

I filed a PR that gets the Backdrop-side of things working (CKE5 only at this point). It can insert an accordion but it's not usable yet. The upcast/downcast code is the tricky part that remains to be done, as well as adding balloon toolbar support for adding/removing accordion items.

indigoxela commented 7 months ago

We could (sort of) feature-freeze CKE4 support and update or enhance only CKE5 version (if that's possible...).

The upcast/downcast code is the tricky part ... balloon toolbar...

Yeah... CKE5 :shrug:

indigoxela commented 3 months ago

I wonder, if anyone already tested this existing pull request: https://github.com/backdrop-contrib/ckeditor_accordion/pull/10

It's around for a while now, but nobody seems to have given it a try, yet, maybe people just missed, that it exists.

Note also, that there's an alternative implementation with TinyMCE integration (fully compatible).

olafgrabienski commented 3 months ago

I wonder, if anyone already tested this existing pull request: https://github.com/backdrop-contrib/ckeditor_accordion/pull/10

I didn't, because it's supposed to be "not usable yet".