search

backdrop-contrib / coder_review

"Developer module" which reviews your code identifying coding style problems and where updates to the API are required.
GNU General Public License v2.0
1 stars 7 forks source link

Issue 12 update php codesniffer #14

Closed hosef closed 2 years ago

hosef commented 4 years ago

This PR updates the sniffs in Coder Review to work with phpcs ^3.0. As a side effect of using a version pf phpcs greater than 2.*, we have a minimum PHP version requirement of 5.4.

Fixes #12.

jenlampton commented 4 years ago

I'm not sure exactly what this means... 

 Code review initiated:

##[error]Process completed with exit code 255.
Run ~/.composer/vendor/bin/phpcs --standard=Backdrop --extensions=php,module,inc,install,test,css,info,txt,md ./

PHP Fatal error:  Interface 'PHP_CodeSniffer_Sniff' not found in /home/runner/coder_review/coder_sniffer/Backdrop/Sniffs/Classes/InterfaceNameSniff.php on line 20
PHP Stack trace:
PHP   1. {main}() /home/runner/.composer/vendor/squizlabs/php_codesniffer/bin/phpcs:0
PHP   2. PHP_CodeSniffer\Runner->runPHPCS() /home/runner/.composer/vendor/squizlabs/php_codesniffer/bin/phpcs:18
PHP   3. PHP_CodeSniffer\Runner->init() /home/runner/.composer/vendor/squizlabs/php_codesniffer/src/Runner.php:70
PHP   4. PHP_CodeSniffer\Ruleset->__construct() /home/runner/.composer/vendor/squizlabs/php_codesniffer/src/Runner.php:332
PHP   5. PHP_CodeSniffer\Ruleset->registerSniffs() /home/runner/.composer/vendor/squizlabs/php_codesniffer/src/Ruleset.php:217
PHP   6. PHP_CodeSniffer\Autoload::loadFile() /home/runner/.composer/vendor/squizlabs/php_codesniffer/src/Ruleset.php:1159
PHP   7. include() /home/runner/.composer/vendor/squizlabs/php_codesniffer/autoload.php:167
##[error]Process completed with exit code 255.