search

backdrop-contrib / coder_review

"Developer module" which reviews your code identifying coding style problems and where updates to the API are required.
GNU General Public License v2.0
1 stars 7 forks source link

Create a new branch for PHPCS updates? #16

Open jenlampton opened 4 years ago

jenlampton commented 4 years ago

Should we create a new branch to hold the updated version of PHPCS? See https://github.com/backdrop-contrib/coder_review/issues/12

jenlampton commented 4 years ago

@quicksketch recommended a new branch in the meeting today, but I'm opening this issue because I'm not sure that's the best course of action.

We're currently following the drupal version numbering for Backdrop contrib projects, and if the Drupal version of coder includes support for PHPCS 3.3.1 already, shouldn't our version of coder_review align with the Drupal version to indicate that we also include support for version 3.3.1?

hosef commented 4 years ago

@docwilmot How would you like to handle the update to the version of phpcs that we are using? I created a PR at #14, and we can merge it into the main branch or we could create a new branch for the new version of phpcs.

izmeez commented 10 months ago

Is there any progress on this issue?

izmeez commented 10 months ago

In the zulipchat https://backdrop.zulipchat.com/#narrow/stream/218635-Backdrop/topic/Backdrop.20code.20sniffs/near/396726772 there is a mention of the difference between the sniffs in the coder_review module and https://github.com/backdrop-ops/phpcs which was completely rewritten for the new version of phpcs.