search

backdrop-contrib / coder_review

"Developer module" which reviews your code identifying coding style problems and where updates to the API are required.
GNU General Public License v2.0
1 stars 7 forks source link

Issue #12: Upgrade to latest version of PHPCS. Matching Drupal 8.3.12 version. #18

Open quicksketch opened 3 years ago

quicksketch commented 3 years ago

Fixes https://github.com/backdrop-contrib/coder_review/issues/12.

This is an alternative to https://github.com/backdrop-contrib/coder_review/pull/14, instead of updating the current rules to work with the new version of PHPCS, this copies the Drupal 8.3.12 version of Coder Module's rules, which better utilize Squidz's libraries rather than recreating our own rules for CSS files and most whitespace handling.

laryn commented 1 year ago

@quicksketch I'm testing this PR and I ran into an issue as described here (and fixed in the minimal patch attached to this comment):

https://www.drupal.org/project/coder/issues/3204177#comment-14705137