search

backdrop-contrib / coder_upgrade

Helps automate some/most of the work required to upgrade a module from Drupal to Backdrop 1.x
GNU General Public License v2.0
4 stars 7 forks source link

Internal/helper functions being ignored. #61

Closed klonos closed 2 years ago

klonos commented 2 years ago

Checking the log after conversion, I see entries like the following:

Ignoring function '_some_module_some_function' as its name does not begin with the module name or 'theme_'

We need to tweak the regex so not to be skipping _module_name_*() functions. Those should be converted too.

klonos commented 2 years ago

PR up for review @bugfolder and/or @docwilmot:https://github.com/backdrop-contrib/coder_upgrade/pull/62

...this is the first time I'm contributing to this module, so not 100% sure if there are other things that I've missed.

bugfolder commented 2 years ago

Tested the PR; works for me.