Warn users on status report screen

backdrop-contrib / d2b_migrate

GNU General Public License v2.0

5 stars 6 forks source link

Warn users on status report screen #14

Closed liberatr closed 8 months ago

liberatr commented 8 months ago

As a site owner, I would like to be reminded that D2B Migrate is a dangerous module to have enabled, so I can remember to disable it.

Especially right now there are not even any access checks on the menu hooks.

I propose at least adding a message to the status screen to remind them to turn off this module if they're not using it.

docwilmot commented 8 months ago

Yes, the menu hooks definitely need access checks; I'd say admins or user 1 only probably. In which case I dont think a warning would be needed. If youre an admin and you run this module all the way through the wizard "accidentally", something would need to be seriously wrong with you.

quicksketch commented 8 months ago

Thanks @liberatr! I'm helping @irinaz with this module this weekend.

I pushed a commit to your PR with a few changes:

Moved hook_requirments() to an .install file
Downgraded from a REQUIREMENT_ERROR to REQUIREMENT_WARNING
Updated the requirement message with links to both run the migration and to disable the module.