Do not include modules disabled in D7 into list of downloadable modules

[irinaz]

In step "Database Analysis" do not include modules that are disabled in D7 into list of downloadable projects, only modules that are enabled in D7. Often sites have many modules that have been disabled, including custom or outdated modules, and listing them in the new Backdrop site creates clutter.

https://github.com/backdrop-contrib/d2b_migrate/blob/1.x-1.x/d2b_migrate.module#L580

[docwilmot]

Or maybe include them but uncheck the checkbox and/or add a "disabled in source" notification or icon?

[irinaz]

Uncheck by default and "disabled in source" in the column where we show "in core/downloaded/available/ not ported yet) will work well. It allows to show information about old system without actually downloading. For example, we are using D7 distribution with 304 module of which 118 are disabled.

[irinaz]

I tested module and it is still downloading projects that were unchecked

[docwilmot]

This should be fixed

[irinaz]

I still see modules that are disabled in the D7 source website in the list of modules on the new backdrop site.

[docwilmot]

I dont understand what you mean. When you click "Download available projects" does D2B download unchecked modules?

[irinaz]

My intent here was to check if a module is enabled in D7, and not include it into list if it is disabled. For example, in one of my demo projects Biblio module is disabled, but it shows up in the list of modules available for download. Let me know if this explains my request better. Thank you so much for working on this module!!

D7 list of modules

Backdrop database analysis

[docwilmot]

Please recall this conversation which was implemented in the last commit.

[irinaz]

@docwilmot , thank you for reminding me about https://github.com/backdrop-contrib/d2b_migrate/issues/32#issuecomment-1837652285 and adding a screenshot here with new implementation. I will double check that "biblio" module quoted in my comment is not checked and I can see (Disabled in source) text.

[irinaz]

@docwilmot, I created new site, downloaded most recent version of d2b module, connected to D7 database, and I do not see "(Disabled in source)". I changed line 483 to the following and this way modules are showing in the list exactly as described in #32. Let me know if I should file PR or you can update code directly. Thank you so much for making it all work! if ( $project['project_status'] == 0) {

[docwilmot]

Was a PHP version issue I think. I had version 7.4 local and indeed it didnt work when I switched to version 8.2. Fixed now I believe. Please try again.

[mue368]

Today I tried to migrate my clean Drupal 7 version with the latest Backdrop and d2b_migrate version. I have already deactivated AND uninstalled all modules that are no longer available in Backdrop. Then I performed a new Backdrop installation in the German language, specified the paths for the private file system in the Backdrop configuration, manually downloaded all necessary Backdrop modules to the Backdrop path "modules" and copied the files from the public file system of the old Drupal installation to Backdrop. This is exactly the same as the standard Backdrop upgrade procedure. I use PHP version 8.1 on my development server. In the 2nd step "Source analysis" of the module d2b_migrate it is mentioned above that after clicking on "UPDATE PROJECT DATA" checkboxes should be visible for each module found. However, this is not the case for me. There is no selection option at all: So if there is a problem with the PHP version, this is unfortunately not fixed. Thank you very much.

[docwilmot]

This is strange. I cannot understand why the checkboxes would not show. Are there any errors in your logs? Javascript errors? The tableselect code is not conditional in any way, it shouldnt disappear.

[mue368]

It does not seem to be due to the PHP version. I temporarily reverted to version 7.4.26 and the error persisted. Of course, I also deleted all caches several times in between and ran update.php. No errors were displayed. In the meantime I have unfortunately deleted the DB again and am trying another standard update. Unfortunately, there are always errors so that you need several attempts. The errors look like this:

[docwilmot]

We expect errors, but the image in https://github.com/backdrop-contrib/d2b_migrate/issues/32#issuecomment-1872387384 is unexpected. Is the sidebar task list missing too? Can you show the whole page?

[mue368]

I have now reinstalled everything with PHP version 7.24 and English language. I have also left the default download method as standard: I have activated the output of ALL messages. When I call up the Source analysis step, I get the following output: The note on the empty Port field is certainly irrelevant. As I use the standard port, nothing needs to be entered there. The checkboxes are still not visible. There is also no entry in the source code:

[yorkshire-pudding]

I've tested the latest version and I now get the checkboxes unchecked and with the suffix "(Disabled in source)"

[docwilmot]

@mue368 are you using the latest version from GitHub?

Edit: no you're not! Just realized your UI is the very old version. The new changes are not released yet sorry.

[irinaz]

@docwilmot, @quicksketch , I think that it is definitely worth doing new release with the new code, even if there are some minor bugs. It would be such an amazing achievement in 2023!!! Thank you so much !

[docwilmot]

Thanks @irinaz. We'd need comments on the issue queues specifying which issues are resolved and which still have bugs before we release. We need testing in other words.

[irinaz]

This is issue has been tested, and is ready for release.