Closed elisseck closed 6 days ago
No, that's probably a mistake :/ Thank you for finding it!
On Thu, Nov 7, 2024 at 10:36 AM Eli Lisseck @.***> wrote:
@jenlampton https://github.com/jenlampton do you remember if there is a reason why this is commented out (as opposed to either running or removed entirely)? I can create a PR if there isn't one: https://github.com/backdrop-contrib/d7compatible/blob/e68e5c94b7833c4da9c306057967c782ad444454/template.php#L53
I am seeing warnings on node pages for ported themes using this compatibility layer unless I un-comment that line:
Warning: Undefined variable $title_attributes in include() (line 88 of /var/www/backdrop.local/web/themes/d7compatible/templates/node.tpl.php).
— Reply to this email directly, view it on GitHub https://github.com/backdrop-contrib/d7compatible/issues/5, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADBER2DEXM6V6DBRMUD3NLZ7OXMFAVCNFSM6AAAAABRL274AKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY2DCOBVGAZDMMQ . You are receiving this because you were mentioned.Message ID: @.***>
FIxed in 6194c869c77518de8b5fd58b65220db451d3fadb
and should be included in https://github.com/backdrop-contrib/d7compatible/releases/tag/1.x-1.0.2
@jenlampton do you remember if there is a reason why this is commented out (as opposed to either running or removed entirely)? I can create a PR if there isn't one: https://github.com/backdrop-contrib/d7compatible/blob/e68e5c94b7833c4da9c306057967c782ad444454/template.php#L53
I am seeing warnings on node pages for ported themes using this compatibility layer unless I un-comment that line:
Warning: Undefined variable $title_attributes in include() (line 88 of /var/www/backdrop.local/web/themes/d7compatible/templates/node.tpl.php).