search

backdrop-contrib / date

NOW IN BACKDROP CORE 🎉 Adds a date field.
GNU General Public License v2.0
0 stars 0 forks source link

Date formats not correct #2

Open jdanthinne opened 9 years ago

jdanthinne commented 9 years ago

I think all return values from _system_get_dateformats() class (there are a lot of them in this module) should be handled differently, because they don't return the same values as before, and this module is unusable right now (see Default values in the field admin ie.).

Graham-72 commented 9 years ago

I see what you mean. I will work on it.

Graham-72 commented 9 years ago

I have now made an alteration to function date_format_type_options in date/date_api/date_api.module but there seem to be other issues and maybe this is a whole can of worms!

I note that system_get_date_formats() produces quite different results in Backdrop compared with Drupal7 - see images. In Backdrop: backdrop_systemdateformats And in Drupal 7: drupal7_systemdates

Other related issues: backdrop/backdrop-issues/issues/838 backdrop/backdrop-issues/issues/804 backdrop/backdrop-issues/issues/709 backdrop-contrib/date#1 backdrop-ops/contrib#76 https://api.backdropcms.org/node/41663

jdanthinne commented 9 years ago

Yes, I also thought this was a simple change to do, but since this function is called so many times, I didn't know where to solve the problem… in core or in the module.

Graham-72 commented 9 years ago

Now that we have Backdrop 1.1, I have resumed work on porting Date and tackling the various problems we have found. I am now attempting to avoid and remove some of the additional format options added in Date for Drupal because Backdrop already has good facilities in core. Hopefully I will have some revisions to publish soon.

ghost commented 9 years ago

I just posted this, due to an issue with date_popup_formats(): https://github.com/backdrop/backdrop-issues/issues/974