backdrop-contrib / demo

Manage snapshots of a Backdrop site for demo purposes.
https://backdropcms.org/project/demo
GNU General Public License v2.0
1 stars 3 forks source link

Fixes #35: Add watchdog entry at start of creating a snapshot #38

Closed robertgarrigos closed 1 month ago

robertgarrigos commented 1 month ago

fixes #35

izmeez commented 1 month ago

@robertgarrigos Adding an extra line at 214 doesn't appear to be necessary.

Adding an extra comment to the start of the next hunk may add consistency: // Create watchdog notice for reference.

Otherwise this looks good.

izmeez commented 1 month ago

Also, I wonder if the line that is added to watchdog should be changed, removing the for and adding a comma? 'Created snapshot, %filename'

robertgarrigos commented 1 month ago

@izmeez how about a colon (:)? ;-)

izmeez commented 1 month ago

A colon will be fine.