7.x-1.5 to 7.x-1.6 cross-ports

[klonos]

I am assuming that I need to start from 7.x-1.5, since the first release of the Backdrop port claims to have parity with that version: https://github.com/backdrop-contrib/devel/releases/tag/1.x-1.5

• [x] #64 | dcf7727 | Remove xhprof integration. Please use xhprof module. Or if you prefer a non-Drupal solution, see xhgui or xhprof.io
• [x] #59 | 1be2fe3 | Issue #1919460 by sun, mr.baileys: Fixed Bogus query parameters in devel switch user links.
• [x] #60 | 75f228f | Issue #2130357 by vbouchet, upupax: Fixed Drush generate content create empty title.
• [x] #61 | 673ce9e | Issue #2324027 by alberto56: Fixed devel_generate_content_add_node() in devel_generate/devel_generate.inc: wrong @param documentation.
• [x] #62 | b096916 | Issue #2366797 by salvis: Running dpm()/krumo() on changes ->user to 1.
• [x] #63 | 9e4a40f | Issue #1858318 by dalin: Make debugging EFQ easier by implementing hook_query_alter()
• [x] #64 | 9d89e71 | Issue #2471058 by geerlingguy: Remove the rest of the XHProf integration
• [x] #65 | d734bda | Issue #2465025 by willzyx: SQL query log doesn't work on pages generated by a view
• [ ] N/A | 953e662 | Issue #2343269 by david.hughes: JavaScript error while generating menus
• [x] #66 | 566318b | Issue #2429787 by Dave Reid: Fixed file generation should use file_unmanaged_move() instead of file_move() before the file_save() has been called.
• [x] #66 | 98011ab | Pass a directory to file_unmanaged_move() instead of the full path. (follow-up to #2429787
• [x] #67 | b313536 | Issue #2594989 by Jacine: devel_krumo_path.js causes request for help.png when not in use
• [x] #68 | 34e948a | Issue #2593435 by Sagar Ramgade: Fix double occurence of "is" in devel_shutdown_real
• [x] #69 | 62d53dd | Issue #1190074 by simanta, greggles, joachim: Show real arguments instead of placeholders in query log.
• [x] #70 | 0cb3c81 | Issue #2561457 by alan-ps, Jeroen94: Undefined variable "node" in comment_view() on comment/%/devel/render.
• [x] N/A, but see https://github.com/backdrop-contrib/devel/issues/49#issuecomment-508888707 | 66b4095 | Issue #2653284 by Zoltán Balogh: Remove string concatenation from menu item descriptions.
• [ ] #xx | 8868652 | Issue #1918302 by TravisCarden: Remove executable bits from krumo file permissions
• [ ] PR blocked by previous, unmerged changes. See #72#issuecomment-508889461 | f047d41 | Issue #2654578 by hey_germano: Add devel_generate property to files and terms created by Devel Generate
• [ ] #xx | cadea9a | Issue #2381779 by DuaelFr, salvis: Various files in Krumo have incorrect line endings and other white space errors (no functional changes).
• [x] #73 | 196a1eb | Issue #2381779 by salvis, TravisCarden: Rename Interface.PNG to Interface.png (no functional changes, the file is not actually used).
• [x] #74 | 643407c | Issue #2559061 by dagmar: Fatal error: Cannot redeclare dd().
• [x] #75 | de728df | Issue #927690 by joe_carvajal, Mav-im, torotil: Add support to dsm() and dpm() for protected or private object fields.
• [x] #76 | 2f0db7d | Issue #2606018 by RoSk0, das-peter: devel_switch_user_form_submit() creates wrong token.
• [ ] N/A | 55ad8ae | Issue #2879092 by Aron Novak: Generating text - PHP 7.1 warning.
• [ ] N/A | 36151ff | Issue #2750963 by JvE: Generating field text fails if max length is less than 6.
• [x] #77 | 48def5e | Issue #2065225 by maximpodorov: Wrong usage of substr in krumo.
• [ ] N/A, but see https://github.com/backdrop-contrib/devel/issues/49#issuecomment-508888707 | 496880d | Issue #1169726 by salvis: Hard-coded links in menu item descriptions makes it impossible to translate them.
• [ ] N/A; see https://github.com/backdrop-contrib/devel/issues/49#issuecomment-508894547 | 8f20578 | Issue #2394661 by aramboyajyan: Use default Krumo skin when no skin is defined.
• [ ] N/A | ac84bb1 | Issue #2111127 by jacob.embree, salvis: Fix variable dev_timer, should be named devel_timer.
• [x] #78 | 4edd3d4 | Issue #1257584 by jacob.embree, zorya: Devel Variable Editor: Wrap variable names in LABEL tags.
• [x] #79 | 8f86f71 | Issue #2933660 by jacob.embree, zorya: Include fragment in link to rebuild registry.
• [ ] #xx | 752a1ca | Issue #2855666 by joseph.olstad, MustangGB, Nick Robillard: Make Krumo compatible with XSS injection protection to drupal_set_message()
• [x] #51 | 991250a | Issue #269984 by jacob.embree, zorya, salvis: Coding standards (comments).
• [ ] #xx | bd4061f | Issue #2959508 by salvis: Fix PHP 7.2 Incompatibility - count(): Parameter must be an array...
• [ ] #xx | 7fe21b2 | Issue #2448063 by jacob.embree, zaporylie: Add #actions container to submit buttons
• [ ] #xx | cbc82b7 | Issue #541342 by zorya, salvis: Display message about Devel block missing because Menu is not enabled.

---

git log 7.x-1.5..7.x-1.6 --reverse --no-merges --pretty=format:"- [ ] #xx | [%h](http://git.drupalcode.org/project/[project_name]/commit/%H) | [%s](http://drupal.org/project/devel/issues/" | sed -E "s/^(.*#)([[:digit:]]*)(.*)$/\1\2\3\2)/g"

[klonos]

Hey @quicksketch 👋 ...the D7 module decided to remove support for XHProf in https://git.drupalcode.org/project/devel/commit/dcf77278a96b1275cae5866970048f54c19f34ff and http://git.drupalcode.org/project/devel/commit/9d89e71e19b57a6c55ee78f4ddc14b9a1b55d9da ...they now recommend using https://www.drupal.org/project/xhprof instead. Do you think we should be doing the same in the Backdrop port, or retain support?

See:

https://www.drupal.org/project/devel/issues/1848378 https://www.drupal.org/project/devel/issues/2166165 https://www.drupal.org/project/devel/issues/2471058

Edit: I've filed a PR for it in case you agree to have it removed: https://github.com/backdrop-contrib/devel/pull/64

[klonos]

https://www.drupal.org/project/devel/issues/2653284 | https://git.drupalcode.org/project/devel/commit/66b409593700194623ed486fed58528ab85a68ec is not applicable to us, but that commit implemented "a fix" that was not an actual fix for the problem reported:

Please, remove the string concatenation from menu item's descriptions, because in this format only the first parts of the strings are translatable.

Instead of moving the URLs inside the strings, they should have used @ references, and still use url().

Anyway, that commit made it apparent that menu titles and descriptions were not passed through t() (so would not be translatable anyway), so I have filed a PR that wraps these in t() (and also fixes a few double spaces here and there): https://github.com/backdrop-contrib/devel/pull/71

Edit: same deal with http://drupal.org/project/devel/issues/1169726 and the respective commit in http://git.drupalcode.org/project/devel/commit/496880dc719967db8e31b42add5e368258c70a68

[klonos]

I want to mark http://drupal.org/project/devel/issues/2394661 | http://git.drupalcode.org/project/devel/commit/8f20578af2068c02587ba9a664ef411c38569ae2 as N/A, but wondering re this bit:

https://github.com/backdrop-contrib/devel/blob/1.x-1.x/lib/krumo/class.krumo.php#L676

    $css = '';
    // DEVEL: changed for Backdrop config system.
    $skin = config_get('devel.settings', 'krumo_skin');
    if (!$skin) {
      $skin = 'default';
    }

I see that we ship the various available skins in https://github.com/backdrop-contrib/devel/tree/1.x-1.x/lib/krumo/skins, but I don't see this 'krumo_skin' setting in the admin UI in admin/config/development/devel (and there is no reference to it in https://github.com/backdrop-contrib/devel/blob/1.x-1.x/devel.admin.inc). Am I missing something?

Edit: ...we seem to have removed this option: https://github.com/backdrop-contrib/devel/commit/8d3d66085407bb8816180a7d4c70923e66d592e5