search

backdrop-contrib / diff

Show differences between content revisions.
GNU General Public License v2.0
0 stars 5 forks source link

fixes revision access to users with view revision access #7

Closed robertgarrigos closed 4 years ago

robertgarrigos commented 6 years ago

it fixes #6

Graham-72 commented 6 years ago

@robertgarrigos I think there is more needed to fix this issue and it seems the porting is incomplete or incorrect. I am going to investigate what else needs doing.

robertgarrigos commented 4 years ago

in fact, there is: https://api.backdropcms.org/api/backdrop/core%21modules%21node%21node.module/function/_node_revision_access/1

Graham-72 commented 4 years ago

Yes, my mistake. I was misled by the function name beginning with an underscore (_node_revision_access) which does not conform to our naming convention. Now I am wondering about the purpose of using this function here in diff module. I am in the process of preparing another PR that will make a change to function diff_node_revision_access because of sorting out the config settings references. I think adding some comments in here might also be helpful, to explain what the function is doing.