search

backdrop-contrib / domain

A domain-based access control system for Backdrop CMS
https://backdropcms.org/project/domain
3 stars 5 forks source link

Domain Blocks #17

Closed stpaultim closed 6 months ago

stpaultim commented 6 months ago

Get blocks working for domain.

My colleague wrote the following.

I tried to port the Domain Block module into the Backdrop CMS. After some RND I realized Backdrop moved visibility conditions into the layout section.

So I added the Domain-specific visibility conditions into the Domain module using the access plugin, now you can add domain-specific visibility conditions from the layout and we do not need to convert the Domain Block module into the Backdrop CMS.

Does this make sense?

stpaultim commented 6 months ago

Atten @yorkshire-pudding

izmeez commented 1 month ago

I am assuming this was closed with this commit adding support for blocks. Does this need to be added to the new 1.x-3.x branch or is it already taken care of? Does this issue need to be re-opened until confirmed?

izmeez commented 1 month ago

The two ports are using the same solution just at different paths.

The 1.x-3.x-old adds a new file with path plugins/access/domain_layout_access.inc and contents shown in commit

while the 1.x-3.x branch includes a new file at /plugins/layout/access/domain_layout_access.inc the contents of which appear to be the same.

So the question becomes what is the best path to use with or without extra nesting? Maybe less or no nesting is best? Possibly just plugins/domain_layout_access.inc ?