search

backdrop-contrib / entity_plus

This module wraps in a variety of additional entity-related functionality from various sources. Partial port of D7 Entity API.
https://backdropcms.org/project/entity_plus
GNU General Public License v2.0
3 stars 11 forks source link

Prepare wrappers for PHP 8.2 #159

Closed argiepiano closed 11 months ago

argiepiano commented 1 year ago

Entity metadata wrapper classes all use dynamic properties to get or set values for entity fields. For example, this is very common: $wrapper->my_field->value(); where my_field is a dynamic property of the wrapper, and corresponds to the entity's my_field field.

The solution I'm proposing is to add #[AllowDynamicProperties] to the base wrapper class. PR coming.

argiepiano commented 1 year ago

PR #159. @laryn, @hosef please take a look when you have a chance.

hosef commented 12 months ago

@argiepiano This looks like a straightforward change, and I can't imagine it would break anything.

I think it would be fine to merge this.

argiepiano commented 11 months ago

Thanks