search

backdrop-contrib / entity_plus

This module wraps in a variety of additional entity-related functionality from various sources. Partial port of D7 Entity API.
https://backdropcms.org/project/entity_plus
GNU General Public License v2.0
3 stars 11 forks source link

Vocabulary test failure after https://github.com/backdrop/backdrop-issues/issues/6197 #164

Closed argiepiano closed 5 months ago

argiepiano commented 11 months ago

The changes to TaxonomyVocabulary made in https://github.com/backdrop/backdrop-issues/issues/6197 are causing a Vocabulary metadata test to fail.

The issue is that, in that core commit, the property TaxonomyVocabulary::original was explicitly declared in the class. This results in all new Vocabulary objects to contain an original property with value null. The particular tests that fail compare two vocabularies after unsetting original. This approach doesn't work anymore. Instead of unsetting, the test should assign a null value to original before comparing.

I don't expect the changes in TaxonomyVocabulary will cause any other issues with metadata wrappers.

PR coming

argiepiano commented 11 months ago

PR submitted and ready for review.

argiepiano commented 11 months ago

Test now passes!

argiepiano commented 5 months ago

@hosef, @laryn, any chance you can review this so that we can get tests passing again?

laryn commented 5 months ago

LGTM, merged!