search

backdrop-contrib / facetapi

An abstracted facet API that can be used by various search backends.
GNU General Public License v2.0
0 stars 3 forks source link

PHP 8.1: Deprecated function: Return type of FacetapiFacet::offsetExists($offset) should either be compatible with ArrayAccess #14

Closed argiepiano closed 10 months ago

argiepiano commented 1 year ago

When running this module on PHP 8.1, I'm getting:

Deprecated function: Return type of FacetapiFacet::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in require_once() (line 1131 of... Sites/localhost/panettone/modules/facetapi/plugins/adapter.inc).

This is similar to several other places in core and contrib where we've had to add #[\ReturnTypeWillChange] right above the offending methods.

herbdool commented 1 year ago

@argiepiano feel like making a PR? I can test it and we can merge it later as part of Bug Squad.

argiepiano commented 1 year ago

Done! PR #18

herbdool commented 1 year ago

LGTM

argiepiano commented 10 months ago

I'll merge this, since it was LGTM back in August.