Deprecated functions in PHP 8

backdrop-contrib / facetapi

An abstracted facet API that can be used by various search backends.

GNU General Public License v2.0

0 stars 3 forks source link

Deprecated functions in PHP 8 #21

Closed argiepiano closed 1 year ago

argiepiano commented 1 year ago

Deprecated function: Return type of FacetapiFacet::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in require_once() (line 1131 of /Users/XXX/Sites/localhost/XXX/modules/facetapi/plugins/adapter.inc).

argiepiano commented 1 year ago

PR #20 ready for review.

argiepiano commented 1 year ago

@backdrop-contrib/bug-squad, I don't think the maintainer, @earlyburg, is active anymore. Can someone review and merge please?

argiepiano commented 1 year ago

Oops! I had submitted the same fix back in August, issue #14. Closing this one.