search

backdrop-contrib / field_collection

Field Collection provides a field for entities (nodes, users, taxonomies, comments, etc.) to which a collection or group of any number of fields can be included and treated as a whole or single unit.
GNU General Public License v2.0
0 stars 7 forks source link

Get functional tests running #18

Open indigoxela opened 3 hours ago

indigoxela commented 3 hours ago

... and run them via GitHub Action on PRs.

indigoxela commented 2 hours ago

I did what I could to get them running. And I did have to fix some details in field_collection.entity.inc, field_collection.module and field_collection.pages.inc to get them running.

4 tests still fail and they seem to fail rightly - something with host cloning and revisions and fields seems fishy, but I'm not planning to spend more time on those - I'm not familiar enough with the module to decide, which changes are appropriate to fix the bugs.

Anyway, here's a PR #19 for your kind review @oadaeh

The GHA should run on PR, but doesn't do that, yet, as I'm not admin of this repo - it requires merge before the action runs. But tests can get run locally, already.