search

backdrop-contrib / flag

Flag module for Backdrop CMS
0 stars 11 forks source link

Update maintainers in README.md? #12

Closed herbdool closed 3 years ago

herbdool commented 5 years ago

@jenlampton this project is abandoned. ~We should change the README to "seeking maintainers".~ All recent commits are by people other than the maintainer (who has had no activity on this project for a few years).

~PR https://github.com/backdrop-contrib/flag/pull/13~

Update: I'm willing to maintain this module so a new PR coming.

jenlampton commented 5 years ago

Thinking about this more...

I'd prefer to leave the maintainer's name on a project, even if they have not contributed to it in a few years. Having someone as the go-to person if there is a security issue is better than having no one at all. A previous maintainer is still going to be more knowledgeable about the project than the Security Team.

I think it would be reasonable to add "Seeking additional maintainer(s)" to the README.md file -- assuming the current maintainer either agrees, or does not respond to this issue in 2 weeks. But removing maintainers (with no one stepping up as a replacement) may hurt the situation more than help.

@herbdool Let's leave this issue for 2 weeks. If @jromine agrees here (or does not respond in 2 weeks) then we can merge a PR.

edit: This might need a vote of the PMC? What do you think? (and definitely needs an update to our contrib maintainer agreement!)

herbdool commented 5 years ago

I changed the PR. I think better to put John under Credit so he's still in the README, but it's clear he's not maintaining it at all. Does that address your concern?

jenlampton commented 5 years ago

Does that address your concern?

Not if there are no maintainers listed. It's better to have a name there than not to have one.

I think your concern might be better handled by the "Maintenance status" taxonomy recently added to backdropcms.org than by removing our "in case of emergency contact".

edit: Here's the corresponding issue for backdropcms.org: https://github.com/backdrop-ops/backdropcms.org/issues/515

jromine commented 5 years ago

I have no objection to someone else maintaining this. I'm not actively using it myself at present.

jenlampton commented 5 years ago

@jromine we don't have a volunteer to be a new maintainer yet, so would you be comfortable remaining the maintainer until we do? We understand that you aren't actively working on the project, but it would still be good to get your help should any security issues arise.

herbdool commented 5 years ago

The problem with leaving someone on who isn't active is that no one has permission to accept any PRs, whereas if there are none, then it's acceptable. Maybe not the best option but it works more or less.

I can ask if anyone wants to be a co-maintainer and I'll consider it myself.

jenlampton commented 5 years ago

The problem with leaving someone on who isn't active is that no one has permission to accept any PRs

That doesn't change until we get another maintainer. Either @jromine has permission but doesn't do it very often, or no one has permission at all.

whereas if there are none, then it's acceptable

Hm, does it say that somewhere? IIRC there needs to be a maintainer for anything to get merged by anyone other than the Bug Squad (and the Bug Squad can merge bug-fixes even if there is a maintainer).

If a module is unmaintained, it seems like a very bad idea for anything other than a bug-fix to get merged. Someone needs to be responsible for vision and priorities or the project is likely to end up a huge mess.

jromine commented 5 years ago

@jenlampton I'm willing to continue being the maintainer, and will help should any security issues arise. If someone else wants to take a more active role as maintainer, I am happy to step aside.

jenlampton commented 5 years ago

@jromine Thank you, that's ideal for us :)

jenlampton commented 5 years ago

@herbdool In the meeting today we decided that we need to really clarify what it means to be a maintainer, what it means for a project to be abandoned (vs just minimally maintained, or not maintained) and what the Bug Squad can do, and when. Once we have all those things ironed out (and agreed to!) we should revisit this issue.

Here's the updated PR for adding the bug squad info: https://github.com/backdrop-ops/contrib/pull/184 And the issue: https://github.com/backdrop-ops/contrib/issues/185

Feedback welcome! :)

herbdool commented 3 years ago

I'm willing to help maintain this module. @jromine you had previously said you'd step aside if someone else wished to be a more active maintainer. I'm happy with either just adding my name as co-maintainer or taking it over.

jromine commented 3 years ago

OK by me either way.