search

backdrop-contrib / flag

Flag module for Backdrop CMS
0 stars 11 forks source link

Fatal error, need to update EntityInterface entityType to be static #14

Closed herbdool closed 5 years ago

herbdool commented 5 years ago

Core had an API change. Need an update here like this:

          /**
           * Implements EntityInterface::entityType().
           *
           * @since 1.13.0 This method is now static.
           */
          public static function entityType() {
            return 'entity_test';
          }
herbdool commented 5 years ago

@jromine I've got a bug fix PR https://github.com/herbdool/flag/pull/1

jenlampton commented 5 years ago

I have confirmed this fix works, thanks @herbdool

quicksketch commented 5 years ago

This change is being reverted in core and will be fixed in 1.13.1: https://github.com/backdrop/backdrop-issues/issues/3809

jenlampton commented 5 years ago

Great, closing this issue. The core change will make this change unnecessary (and problematic)