search

backdrop-contrib / flag

Flag module for Backdrop CMS
0 stars 11 forks source link

HTTP error 500 when flagging content #5

Closed jenlampton closed 6 years ago

jenlampton commented 7 years ago

Whenever I flag a node on forum.backdropcms.org I get a HTTP 500 error:

An HTTP error 500 occurred.
https://forum.backdropcms.org/flag/flag/frequently_asked_question/4?destination=node/4
docwilmot commented 7 years ago

This is because entities are now fully classed objects and the flagging entity wasnt. So the entity_insert() and other entity_*() hook implementations in other modules (particularly filter.module's filter_entity_insert() etc) throw an exception when Flag was passing them a STDClass "flagging" object instead of a real classed entity.

THis PR makes a "flagging" a real classed entity.

docwilmot commented 6 years ago

@jromine are you available to review and merge this PR please? Its holding up using Flag on Forums.

jenlampton commented 6 years ago

@docwilmot there should be a patches.txt file in the repo with links to any patches that need to be applied (and their respective issues).

No patch should ever hold up using a project on a site. Here's a post on how to do it for drupal http://www.jenlampton.com/blog/sustainable-development-workflow-patching

On Oct 8, 2017 2:24 PM, "docwilmot" notifications@github.com wrote:

@jromine https://github.com/jromine are you available to review and merge this PR please? Its holding up using Flag on Forums.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/backdrop-contrib/flag/issues/5#issuecomment-335039661, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYSR4J5Wp5wwn26dszcj_HvFRMp8dzEks5sqT1_gaJpZM4Lw_H- .

jromine commented 6 years ago

@docwilmot I don't have an active Backdrop site to test with right now. If you want to remove me as maintainer in the README that's ok with me.

docwilmot commented 6 years ago

OK @jromine I'll review the patches and merge them in if you dont mind then. Did you quit Backdrop?