backdrop-contrib / gdpr_cookies

Control cookies from all sources with tarteaucitron.js to meet GDPR.
GNU General Public License v2.0
0 stars 3 forks source link

Videos not blocked when using "YouTube Field Colorbox" #16

Open sternhagel opened 4 years ago

sternhagel commented 4 years ago

I tried to use GDPR Cookies 1.x-1.3.0 to block access to embedded YouTube-Videos on my Backdrop website (core 1.15.0) with no visible effect.

Steps taken:

Expected behaviour:

Actual behaviour:

Is this a bug in the module, or did I miss something in the configuration? I tested with both "youtube-nocookie.com" and standard "youtube.com" embeds, but there's no difference.

Graham-72 commented 4 years ago

@sternhagel I have tried unsuccessfully to reproduce this issue, using the YouTube Field module to include a YouTube video in a page. I have been seeing this image

However there are other issues that need correcting and so I have used PR #18 to update the tartaucitron scripts to a more recent release. Please could you try this and see if you still have this problem?

sternhagel commented 4 years ago

@Graham-72 thanks very much for your feedback!

Unfortunately it doesn't make any difference for my issue. But I think I found out what the problem is - I'm using the "YouTube Field Colorbox" submodule to load the videos on click in a modal window. The "tarteaucitron" library seems to ignore the YouTube links when coming this way.

I tested switching the video display to "normal", and the videos are getting blocked as expected (as in your screenshot).

Is there any chance to get this module working with "YouTube Field Colorbox" as well?

olafgrabienski commented 3 years ago

I can confirm the module works as expected with YouTube if Colorbox isn't used. Unfortunately, I don't have a solution for the Colorbox use case. I'd suggest however to change the issue title from "YouTube is not getting blocked" to something more Colorbox specific.

sternhagel commented 3 years ago

@olafgrabienski changed the title. Thanks for the suggestion!