search

backdrop-contrib / geofield

Stores geographic and location data (points, lines, and polygons).
GNU General Public License v2.0
0 stars 7 forks source link

Issue #11: Bundle geoPHP library #20

Closed earthday47 closed 4 years ago

jenlampton commented 5 years ago

Thanks @earthday47! The changes to the module itself look quite simple, and very straightforward. :)

Issue #11: Add GeoPHP to project with composer.

Why with composer? Maybe I'm missing something, is there a licensing restriction? Ideally we'd copy/paste the whole library into geofield/libraries and be done.

earthday47 commented 5 years ago

@jenlampton I just typed composer require phayes/geoPHP in the module root. That was the easiest for me to add the dependency. And an update would just be a composer update. But if that's not Backdrop Contrib's usual method, I can move it to libraries like you said.

jenlampton commented 5 years ago

It's fine if you want to use composer to manange the dependency locally, but maybe it would be better if we don't commit any of the composer stuff into the repo. Can you tell composer where to put the library? If so, maybe it can be both easy for you to maintain, and we can keep the repo clean. Maybe just put some of the local composer stuff into .gitignore files?

earthday47 commented 5 years ago

@jenlampton making more sense to me, thanks for linking to that docs page. I updated to move it to libraries/. I'd still like to keep the cloned geophp folder as-is, tho, there's a ton of includes in that main geoPHP.inc one.