backdrop-contrib / geofield

Stores geographic and location data (points, lines, and polygons).
GNU General Public License v2.0
0 stars 7 forks source link

Views proximity filter and field: replace #dependency with #states #36

Closed herbdool closed 1 year ago

herbdool commented 1 year ago

I'm going to add more detail soon, but for now I'd like to just not that the views filter and field are not working. The states seem to be broken at the least.

Update: I'm pretty sure it's because #dependency no longer does anything in Views under Backdrop. I believe elsewhere in core Views they were replaced with #states so we should do that here too. Funnily geofield_proximity_manual already uses #states so can just use that example for all the other plugins.

herbdool commented 1 year ago

Here's the issue where this happened: https://github.com/backdrop/backdrop-issues/issues/40

herbdool commented 1 year ago

@jenlampton @earthday47 I've got a simple PR to fix the UI for proximity field/filter in Views. https://github.com/backdrop-contrib/geofield/pull/38

herbdool commented 1 year ago

@jenlampton reminder about this easy fix in my PR

argiepiano commented 1 year ago

@herbdool I've tested and LGMT!