backdrop-contrib / geofield

Stores geographic and location data (points, lines, and polygons).
GNU General Public License v2.0
0 stars 7 forks source link

Get rid of dependency on Drupal compatibility layer #45

Closed indigoxela closed 5 months ago

indigoxela commented 6 months ago

There are loads of drupal_render() drupal_get_path(), drupal_add_js()... all over the place.

Are there any plans to clean that up?

Otherwise this module would break the site, if the setting backdrop_drupal_compatibility is off.

herbdool commented 6 months ago

@indigoxela if someone creates a PR then the @backdrop-contrib/bug-squad can RTBC and make a bug fix release.

indigoxela commented 6 months ago

Here we go, a PR is available now.

herbdool commented 6 months ago

I've reviewed the PR. All the backdrop replacements exist and work the same as the drupal ones, so I think this is RTBC. Thanks @indigoxela. @jenlampton this PR looks ready.

argiepiano commented 5 months ago

Merging on behalf of the @backdrop-contrib/bug-squad