search

backdrop-contrib / gin

Admin theme with a strong focus on improving the Editorial Experience.
https://backdropcms.org/project/gin
GNU General Public License v2.0
5 stars 2 forks source link

Dark mode always on #139

Closed olafgrabienski closed 2 months ago

olafgrabienski commented 2 months ago

Using the latest code (downloaded yesterday, 8th of July), after installing and enabling Gin as admin theme, the theme gets displayed all the time in dark mode, no matter if the setting is Light, Auto or Dark. The settings get saved (I've checked the configuration file), but the class gin--dark-mode keeps staying in the <html> tag.

PS: Switching between Light, Auto and Dark, sometimes the theme appeared for a while in light mode. It changed however back to dark mode when I clicked "Save".

laryn commented 2 months ago

@olafgrabienski Can you check the latest code to make sure it fixes for your case as well? I was able to replicate and the code I just pushed fixed it for me.

olafgrabienski commented 2 months ago

@laryn Thanks for the update! Updating to the latest code didn't fix the site where I noticed the issue (cleared caches several times). However, the same code works as expected on another site where I hadn't installed Gin before.

laryn commented 2 months ago

@olafgrabienski Can you provide any further information about the site that this didn't help on?

olafgrabienski commented 2 months ago

@laryn Not sure, I'll have a look in the next days. It's however a general test site and as such not important to fix.

olafgrabienski commented 2 months ago

@laryn Today I had another look at my test site. After clearing caches and enabling Gin (I had switched to Seven in the meantime), the "Appearance" modes (Light, Auto, Dark) now work as expected. 🎉