UX: Using a cog wheel icon for the show/hide toggle for the sidebar is confusing, and the button should not be grouped with the form submit buttons

[klonos]

This is to track the respective issue in d.o that I just filed: https://www.drupal.org/project/gin/issues/3461539

I brought this up in Zulip:

It doesn't make sense to have the icon for the button for hiding/showing the sidebar panel be a cog wheel - I think that it should be an x button and that it should be attached to the panel itself. When the panel is hidden, the button only should remain visible, and it should then have a different icon to signify "show". I believe that the "hamburger"/x button icons would work well in this use case (and it's what people are used to as well I believe).

...besides, having the show/hide button next to the form submit buttons is confusing as well.

@laryn:

Maybe start on the Drupal side and see what feedback you get there. If it doesn't get accepted there we can consider it separately.

[laryn]

@klonos I'm merging in upstream changes and see that this was fixed upstream. Here's a screenshot from my local: