search

backdrop-contrib / gin

Admin theme with a strong focus on improving the Editorial Experience.
https://backdropcms.org/project/gin
GNU General Public License v2.0
5 stars 2 forks source link

Minimize Backdrop-specific overrides #29

Closed laryn closed 1 year ago

laryn commented 1 year ago

@klonos on Zulip:

have you considered finding a way to keep the Backdrop-related overrides decoupled from the otherwise original Gin code? (in order to be able to more easily keep up with upstream changes)

laryn commented 1 year ago

@klonos I'm open to suggestions. At the moment I'm using a combination of theme/template overrides to make the markup match what Gin expects, and adapting the CSS in other places to match the markup that Backdrop provides.

I have found a bunch of theme functions that don't use tpl files (rather send back formatted HTML) and have to decide if I want to just replicate those as overrides and adjust the output or not. It made me think of the Atomium theme which had a goal of making all of those little theme functions controllable via tpl files if I recall correctly.

But if we do revert the name to Gin it would probably help to some degree in keeping track closer to upstream. See @saschaeggi's comments in https://github.com/backdrop-contrib/tonic/issues/27 and https://github.com/backdrop-contrib/tonic/issues/26

I have yet to convert the settings from D9-style to Backdrop (which will be quite different) but hopefully the core CSS and tooling for building CSS, etc. can stay fairly tight to upstream.

laryn commented 1 year ago

@klonos I'm renaming the project to Gin, reworking things locally and trying to use theme overrides where possible, and adding a separate _backdrop-overrides.scss file to minimize direct edits to the Gin files. I'll post an update when the branch is updated in the repo.

laryn commented 1 year ago

The 1.x-3.x branch is reworked with this in mind given the new plan to keep the name Gin and keep a link open between the projects.