backdrop-contrib / gin

Admin theme with a strong focus on improving the Editorial Experience.
https://backdropcms.org/project/gin
GNU General Public License v2.0
5 stars 2 forks source link

Dialogs not launching #33

Closed docwilmot closed 1 year ago

docwilmot commented 1 year ago

I get error in console

Uncaught TypeError: The element must be an instance of Element
    at u (once.js?v=1.25.x-dev:2:382)

themes/gin/js/libs/once.js

docwilmot commented 1 year ago

Actually the modal opens below the page: (Views "Add field" dialog)

fullscreenpage

docwilmot commented 1 year ago

OK, I updated to the very latest dev of Backdrop and flushed caches and dialogs now launch fine. Keeping in mind my local was last fetched only 1 month ago, so it probably might be a problem? Leaving this open in case but feel free to close.

saschaeggi commented 1 year ago

@docwilmot modals have been fixed with df9e8af

Please note that we're in a very early unstable state where we have maybe ported 30% of things. So expect a lot of bugs until we're "done" with migrating things. This is a work in progress.

docwilmot commented 1 year ago

I recognized the early state of the project, thanks for all your work. Usually if there is not an open issue for a bug I find I'll open an issue, in case its not apparent to the devs, or its only on my configuration etc.