search

backdrop-contrib / gin

Admin theme with a strong focus on improving the Editorial Experience.
https://backdropcms.org/project/gin
GNU General Public License v2.0
5 stars 2 forks source link

Dialog close button [ X ] is not reachable #34

Closed docwilmot closed 1 year ago

docwilmot commented 1 year ago

On my local the dialogs are partly hidden below the Admin Bar and I cant get to the X to close them.

Screenshot 2023-07-04 154907

laryn commented 1 year ago

@docwilmot Can you test with the latest? I'm not seeing this:

image

docwilmot commented 1 year ago

Unfortunately yes. Screenshot 2023-07-30 132023

But I've just realised as well there is some issue with the z-index going on here because in the image above the page title (the bit that says "Home page") and the breadcrumb actually are above the modal overlay (the breadcrumb is actually clickable while the modal is active), which is what is actually interfering with the ability to click the X.

Also, was going to make another issue but maybe the page title block (or pseudo-block, whatever) is caught in the same z-index issue as seen below.

Screenshot 2023-07-30 132147

In this one when scrolling up, the page title block gets "fixed" with the page title. Screenshot 2023-07-30 132122

laryn commented 1 year ago

@docwilmot Can you test the latest again? Hopefully it's somewhat better, if not complete.

docwilmot commented 1 year ago

Progress! For tall dialogs like the first image in https://github.com/backdrop-contrib/gin/issues/34#issuecomment-1657238866 the dialog's X is still partly hidden under the Admin bar but now it is clickable. I suspect dialogs need a max height relative to the viewport.

laryn commented 1 year ago

@docwilmot I made one more minor z-index adjustment.

docwilmot commented 1 year ago

yep that did it. LGTM