backdrop-contrib / gin

Admin theme with a strong focus on improving the Editorial Experience.
https://backdropcms.org/project/gin
GNU General Public License v2.0
5 stars 2 forks source link

Menu Link Weight and Experimental Sidebar on edit form Error #55

Closed mrlch closed 11 months ago

mrlch commented 11 months ago

Yeah, I love to see gin on backdrop.

When I was trying the Experimental Feature "Sidebar on edit form" I got the following error when used with the Menu Link Weight Module:

Argument 1 passed to _menu_link_weight_get_parent_value_from_element() must be of the type array, null given, called in */modules/menu_link_weight/menu_link_weight.module on line 109

Thank you.

laryn commented 11 months ago

@mrlch Thanks for testing and reporting! Do you feel comfortable trying the latest dev? There's one commit that isn't in a release yet and I'm curious if it makes any difference.

mrlch commented 11 months ago

Yes, were I can get the dev-version?

laryn commented 11 months ago

@mrlch, you can git clone or git pull from the 1.x-3.x branch of the repo, or download a Zip of the latest dev from the repo's main page:

CleanShot 2023-09-11 at 10 27 01@2x

mrlch commented 11 months ago

Thank you.

with this version the error-message is gone.

But when I try to add a Link to the menu and sort it with drag and drop, The sidebar jumps always to the top. As soon as I try to change the order. Maybe it's also a problem with the paragraph-module on this particular installation.

I'll check it further and report later.

laryn commented 11 months ago

@mrlch Ready for another try?

mrlch commented 11 months ago

yes. I'll let you know.

mrlch commented 11 months ago

With this release the section is shown below the content edit form and not as a sidebar.

Bildschirmfoto 2023-09-12 um 07 46 53

With both versions I have the problem, that as soon as a try to rearrange the navigation, the whole section is duplicated. Here a Screenshot from the previous version.

Bildschirmfoto 2023-09-11 um 20 17 48

laryn commented 11 months ago

@mrlch When you got the latest dev most recently, did you clear caches?

mrlch commented 11 months ago

@laryn yes. I'll later make some tests on a fresh installation were I add modules incrementally to check the behaviour.

mrlch commented 11 months ago

@laryn Good news: a fresh install and everything looks good and functions well.

the steps I took:

  1. Installation of Backdrop
  2. Clone and installation of gin with git clone
  3. Changing admin theme and settings.
  4. First Testing without menu link weight -> was working well
  5. Installing menu link weight via gui and testing -> everything was working well
  6. Installation of Paragraphs and testing -> everything ok.

Bildschirmfoto 2023-09-12 um 16 19 34

I'll later check out with more modules and two languages.

mrlch commented 11 months ago

@laryn I think we can close this issue. I was making some tests with another mature installation. And everything runs well. It seems to me, that in the problematic installation it's a problem with another module. If I find out what's the problem I can open a new issue.

thank you so much for your fast response and your awesome work.

laryn commented 11 months ago

Sounds good @mrlch -- thanks for testing!