backdrop-contrib / gin

Admin theme with a strong focus on improving the Editorial Experience.
https://backdropcms.org/project/gin
GNU General Public License v2.0
5 stars 2 forks source link

Core compatibility of messages #68

Closed robertgarrigos closed 12 months ago

robertgarrigos commented 1 year ago

Demo contrib module styles messages by applying a messages class and the type of message as another class (status, warning, or error). This comes from the messages.them.css core file. I guess many other contrib modules use this (paragraphs does, for instance). This use of core classes produces a very ugly message element in Gin:

Esteu_segur_que_voleu_reemplaçar_la_instantània_ja_existent_Gin____Robert_-_Backhub

Esteu_segur_que_voleu_reemplaçar_la_instantània_ja_existent_Gin____Robert_-_Backhub

Cursor_and_Esteu_segur_que_voleu_reemplaçar_la_instantània_ja_existent_Gin____Robert_-_Backhub

Gin produces the right messages by applying the following classes:

messages messages--status
messages messages--error
messages messages--warning

Wouldn't it be nice to add a core compatibility to show the same gin messages with:

messages status
messages error
messages warning
laryn commented 1 year ago

Thanks @robertgarrigos -- are you on the latest version of Gin? Here's how some of the Demo messages look when I install it:

CleanShot 2023-10-02 at 17 07 19@2x

robertgarrigos commented 1 year ago

mmmm yes, I have the latest version of Gin, but I see it like this:

Are_you_sure_you_want_to_reset_the_site____Robert_-_Backhub

?!

laryn commented 1 year ago

@robertgarrigos I am also having trouble reproducing this one! Can you provide steps?

robertgarrigos commented 12 months ago

Sorry, I can't. It is working fine now. The only thing I have done is updating backdrop during this time. I don't know what was going on.