search

backdrop-contrib / gin

Admin theme with a strong focus on improving the Editorial Experience.
https://backdropcms.org/project/gin
GNU General Public License v2.0
5 stars 2 forks source link

Better visuals on Views Display Menu Tabs #73

Closed laryn closed 1 year ago

laryn commented 1 year ago

I want to improve the Views Display Menu Tabs to communicate more information without having to click into each one. Right now we have rudimentary visual (strikeout) to show a display is marked for deletion but nothing to show if a display is disabled for example:

CleanShot 2023-11-17 at 11 21 17@2x

laryn commented 1 year ago

I've linked a PR for discussion: CleanShot 2023-11-17 at 11 19 49@2x

@saschaeggi Any thoughts on this? Does it introduce clutter or is it helpful?

saschaeggi commented 1 year ago

@laryn it does indeed add noise but that doesn't nessessary need to be a bad thing in this case. What I would really avoid is using a cross icon as users are known to this icon as being a remove action in Drupal (& Gin).

laryn commented 1 year ago

True. Maybe the strikeout is enough for the deletion indicator.

laryn commented 1 year ago

Currently:

CleanShot 2023-11-17 at 13 19 18@2x

saschaeggi commented 1 year ago

Way better :+1:

saschaeggi commented 1 year ago

Do you want to create a MR upstream for this?

laryn commented 1 year ago

@saschaeggi Will do! I'm traveling today so it might not be immediate but it's on my list.

laryn commented 1 year ago

Done.