Auto Darkmode strangeness

backdrop-contrib / gin

Admin theme with a strong focus on improving the Editorial Experience.

https://backdropcms.org/project/gin

GNU General Public License v2.0

5 stars 2 forks source link

Auto Darkmode strangeness #76

Closed laryn closed 8 months ago

laryn commented 1 year ago

I was seeing some strange Darkmode issues that I thought were looking better before and then realized I had it set to "Auto" -- and when I changed it to explicitly be "Dark" it looked better.

laryn commented 9 months ago

I’m going to close this for now and will reopen with details if I see it again.

laryn commented 9 months ago

More info, in the form of a screenshot this time, of blended light/dark mode styles while in "Auto" mode: CleanShot 2024-03-08 at 13 52 50@2x

The gin--dark-mode class is present, so perhaps some CSS overrides for dark mode CSS variables are not getting pulled in properly in the case that the setting is auto.

laryn commented 8 months ago

The fix in #100 helped, but this can still be replicated if Gin is not enabled, but is set as the default admin theme. A strange condition, but one that core apparently allows...

laryn commented 8 months ago

This last remaining case where I'm seeing this appears to be because there are no settings associated with the theme:

If you activate the theme, the defaults get set.
If you visit the settings page and make changes, save, even without activating, settings get saved.

Strange but it looks to me like core strangeness.