backdrop-contrib / gin

Admin theme with a strong focus on improving the Editorial Experience.
https://backdropcms.org/project/gin
GNU General Public License v2.0
5 stars 2 forks source link

Pager on File Browser #95

Closed stpaultim closed 9 months ago

stpaultim commented 11 months ago

I spun up a demo site with dev branch of Backdrop and current release of GIN. This is what the file browser looks like in Seven

image

This is what it looks like with Gin

image

I'm not sure if the page is supposed to be in the right column. But, even if it was intentional, I don't think it works very well.

I'd like to see a pager that looks more like we see with Seven.

Here is a previous issue that has been fixed related to pagers. https://github.com/backdrop-contrib/gin/issues/72

stpaultim commented 11 months ago

I think we should look at the mini-pager as well.

laryn commented 10 months ago

Thanks @stpaultim -- I don't think that is intentional. Can you do some testing on mini-pagers and report back here?

stpaultim commented 10 months ago

Here is the mini pager in Seven image

Here it is in GIN image

I ran across this problem, because I was unhappy with the mini-pager in GIN and thought I would try the full page, which it turned out was even worse.

@laryn

laryn commented 10 months ago

@stpaultim Turns out it was a pretty simple fix to get that reasonable. What do you think of these:

CleanShot 2024-01-10 at 17 05 31@2x

CleanShot 2024-01-10 at 17 06 28@2x

stpaultim commented 10 months ago

Looks better. I'll give it a try on my site with more pages.

@laryn

stpaultim commented 10 months ago

@laryn Sorry, but I'm reopening this issue as well.

The good news is that the full pager looks much better. The bad news is that it's broken.

When I click on a page, on the pager, I go to a blank page. Link is broken somehow.

image

Is this a problem with the theme or something else?

laryn commented 10 months ago

@stpaultim I'm not seeing an issue with the pager functionality on my local -- did you make edits in the Image Library view? Can you try reverting if so, and seeing if it makes a difference?

stpaultim commented 10 months ago

@laryn - I'll do some additional experiments and see if I can figure out what is happening.

I was originally able to reproduce this problem on two sites. One development site we are working on and one fairly clean test site I set up to test CKEditor 5.

I'll do additional testing now and get back to you.

laryn commented 9 months ago

Reopen if this is still an issue.