search

backdrop-contrib / githubapi

GitHub API integration module
GNU General Public License v2.0
0 stars 3 forks source link

Fix the capitalization of "GithubAPI" class? #5

Closed quicksketch closed 8 years ago

quicksketch commented 8 years ago

I'm not sure about this one, but the the word GitHub is always spelled with a capital H. https://github.com/about

It seems that the class GithubAPI be capitalized as GitHubAPI instead then?

This is mostly a matter of preference, it won't affect the actual API itself because PHP is case-insensitive when it comes to class names.

klonos commented 8 years ago

:+1: from me on using capital H in GitHub ...but then again I'm sure you'd expect that from me:

https://github.com/backdrop/backdrop-issues/issues/158#issuecomment-68500999

I think I might have created a monster :wink:

Gormartsen commented 8 years ago

Fixed. I hope I did not miss it anywhere. See: https://github.com/backdrop-contrib/githubapi/commit/56535e4102d6ecf498795aa29cc20fee812fa4ba