korontari
commented
2 years ago
- Gallery mode does not change the default view of the images on the node page. See screenshot to see how images appear in a vertical list by default. This module doesn't seem to do anything to effect the display of these images. The purpose of the module seems to be to solely to create a modal view of images or a modal slideshow of images - that already display on the page.
Exactly, the only purpose of the module is to provide a modal window to see larger version of a node image. The gallery mode just allows user to see other node images without closing the modal.
If this is the case, I would think that it would be REALLY helpful to at least offer the option to display the images in a horizontal line, which is more like a Gallery. I believe that a horizontal display of these images would be a much more common use case. Unless, the assumption is that this module ONLY provides the modal part of the display and assumes that the user will be creating a sub-theme and can change the display themselves.
I understand the point. Usually lightbox modules do not interfere into how the images are composed on node display, leaving that to a theme or to other modules. For example, if image is a part of a View output, then View style plugin is responsible for image placement, not image field formatter. And this module is exactly an image field formatter.
- If I've got 4 images on a node. In Gallery mode, I can click on any image and get a modal of that image as part of a slide show. The slide show has arrows to navigate from one image to the next.
That is intended behavior.
If I TURN OFF gallery mode, it works the same way. Except that when I click on an image, I only see that one image in a modal. BUT, there are still arrows, I just can't use them. It seems really strange to have the arrows visible, but not be able to use them. If there is no need for arrows when NOT in Gallery mode, why show them at all?
That's a good point and I agree that arrows are misleading and should be hidden rather than 'disabled'. As the lightbox functionality is provided by 3d party plugin, I would prefer not to make any changes to it. BUT, this plugin supports custom skins and I suppose I can make a skin and hide these arrows when they are not needed. This still needs to be tested though and I plan to add skins later.
So to sum up, I would say that it is important to make a clear description of the Gallery mode (maybe call this mode differently), rather than change functionality. And improve UI where it is possible without interference in the plugin library. Let me know what you think and I am open to suggestions.
There are a couple of things about the Gallery mode that I found a little strange.
1) Gallery mode does not change the default view of the images on the node page. See screenshot to see how images appear in a vertical list by default. This module doesn't seem to do anything to effect the display of these images. The purpose of the module seems to be to solely to create a modal view of images or a modal slideshow of images - that already display on the page.
If this is the case, I would think that it would be REALLY helpful to at least offer the option to display the images in a horizontal line, which is more like a Gallery. I believe that a horizontal display of these images would be a much more common use case. Unless, the assumption is that this module ONLY provides the modal part of the display and assumes that the user will be creating a sub-theme and can change the display themselves.
2) If I've got 4 images on a node. In Gallery mode, I can click on any image and get a modal of that image as part of a slide show. The slide show has arrows to navigate from one image to the next.
If I TURN OFF gallery mode, it works the same way. Except that when I click on an image, I only see that one image in a modal. BUT, there are still arrows, I just can't use them. It seems really strange to have the arrows visible, but not be able to use them. If there is no need for arrows when NOT in Gallery mode, why show them at all?