i18n_select: option "Select taxonomy terms by language" is missing

backdrop-contrib / i18n

Collection of modules to extend Backdrop CMS multilingual capabilities

https://backdropcms.org/project/i18n

GNU General Public License v2.0

2 stars 5 forks source link

i18n_select: option "Select taxonomy terms by language" is missing #105

Closed olafgrabienski closed 1 year ago

olafgrabienski commented 1 year ago

While I was trying (see related Zulip thread) to configure an exposed Views filter with the goal to show only taxonomy terms of the current user's language, I enabled the i18n_select submodule. That didn't help me with the exposed filter, probably because the appropriate option "Select taxonomy terms by language" on the settings page of the submodule version is missing in Backdrop.

The Drupal module has two options under "Content to filter by language", if "Taxonomy translation" is enabled:

Select nodes by language
Select taxonomy terms by language

The Backdrop version shows only the first option, even if "Taxonomy translation" is enabled.

Screenshot from the Drupal docs:

Screenshot from Backdrop (admin/config/regional/i18n/select):

indigoxela commented 1 year ago

@olafgrabienski many thanks for taking the time to report.

As a first step I'm trying to recreate the setup in D7. It seems to be related to the Variables module, which doesn't exist in B (as the whole concept doesn't exist).

indigoxela commented 1 year ago

A-ha, definitely a bug. :wink:

Getting the form item to show up is the easy part. Not sure, if that already has influence on results. (The update hook is still missing). @olafgrabienski do you have a test site, where you can safely apply patches?

olafgrabienski commented 1 year ago

@indigoxela Thank you very much for looking into the issue! I'll configure a site to test the PR later today.

indigoxela commented 1 year ago

How to test:

Apply the patch
Run the update
Go to /admin/config/regional/i18n/select and turn "Select taxonomy terms by language" on
Make sure, you're using a select list for your exposed filter and not autocomplete

Some caveats:

This setting is a global one, which applies to ALL taxonomy related db queries. Make sure, that other views or pages don't behave weird
This setting isn't applied on the admin/* path by default, so you don't see the effect in the views preview (and other admin paths)

olafgrabienski commented 1 year ago

Tested the PR roughly, works for me!

On my test site, a select list displayed terms in both languages, as described in the issue report. After applying the PR and checking the settings at admin/config/regional/i18n/select, the list displayed only terms in the 'current user's language', as expected.

Regarding the new file i18n_select.install, I did not test to install the patched module (and guess I won't have time the next two weeks).

indigoxela commented 1 year ago

@olafgrabienski many thanks for testing and feedback.

It's fine to not test the update hook. As soon as you save the form after the form item is there, you already have the setting in action.