search

backdrop-contrib / i18n

Collection of modules to extend Backdrop CMS multilingual capabilities
https://backdropcms.org/project/i18n
GNU General Public License v2.0
2 stars 5 forks source link

Compatibility with PHP 8.2 #121

Closed indigoxela closed 1 year ago

indigoxela commented 1 year ago

Not that bad, most submodules seem compatible, but tricky.

Class TaxonomyVocabulary doesn't allow dynamic properties, but i18n_taxonomy seems to create them.

--- Internationalization: Taxonomy translation (I18nTaxonomyTestCase) ----

Status    Group      Filename          Line    Function                            
-------------------------------------------------------------------------------------------------
Exception Deprecated taxonomy_vocabula 65      __construct()                                                           
    Creation of dynamic property TaxonomyVocabulary::$i18n_mode is deprecated
Exception Deprecated taxonomy_vocabula 65      __construct()                                                           
    Creation of dynamic property TaxonomyVocabulary::$langcode is deprecated
...

Not sure yet, if it's possible to workaround that. i18n_mode and langcode property seem pretty essential.

Or... eventually that's not even a problem, but core stuffs everything from form submission or config into the TaxonomyVocabulary object.

Fun fact: if I enforce only defined properties in TaxonomyVocabulary::construct(), all i18n_taxonomy tests still pass. :thinking:

indigoxela commented 1 year ago

With the core fix merged, this module is compatible with 8.2 now.