backdrop-contrib / i18n

Collection of modules to extend Backdrop CMS multilingual capabilities
https://backdropcms.org/project/i18n
GNU General Public License v2.0
2 stars 5 forks source link

Taxonomy Translation Test #21

Closed mazzech closed 3 years ago

mazzech commented 4 years ago

Hi @indigoxela thank you for doing the initial port... here's my first feedback

Screenshot 2020-04-07 at 10 23 45 Screenshot 2020-04-07 at 10 21 27 Screenshot 2020-04-07 at 10 19 09 Screenshot 2020-04-07 at 10 12 57

indigoxela commented 4 years ago

@mazzech many thanks for taking the time to test.

One thing confuses me: your first screenshot shows a totally outdated UI. It should actually look like this screenshot (only one tab "Multilingual support", where the multilingual settings only appear when Multilingual support is checked): multilingual-tab

Maybe your testing instance needs an updated version of i18n?

https://github.com/indigoxela/i18n/archive/i18n-taxonomy.zip

Get the latest zip file (from my fork), unzip and rename to i18n, then flush caches and give testing another try.

mazzech commented 4 years ago

OK, your link is different from mine... I am not used to Github, where do I usually find the right links for testing modules?

https://github.com/backdrop-contrib/i18n/archive/1.x.zip (i used this one, upper right corner of this page) https://github.com/indigoxela/i18n/archive/i18n-taxonomy.zip (seems to be from YOUR repo?)

indigoxela commented 4 years ago

Ah, a misunderstanding... :wink:

The latest changes aren't merged yet. As i18n is a pretty complex module and the changes it needs are rather big, I asked for additional testing in advance.

mazzech commented 4 years ago

No problem...;-) But where do I usually find the right link (also for future testing and for other modules where someone asks for help testing?)

indigoxela commented 4 years ago

@mazzech the link you chose first would usually be the right one to test the current dev (if you want to avoid the usage of git).

indigoxela commented 4 years ago

@mazzech The PR has been merged now. If you're still interested in testing it, you now should download the latest dev version from here https://github.com/backdrop-contrib/i18n/archive/1.x.zip.

(Or git clone, of course, for people who prefer git.)

mazzech commented 4 years ago

Hi @indigoxela

thank you... I still do not the translated term in the respective language (e.g. when editing the node in French)

Screenshot 2020-04-10 at 19 59 37 Screenshot 2020-04-10 at 19 58 57

indigoxela commented 4 years ago

I still do not the translated term in the respective language

Question: what settings does the Vocabulary (TaxOne4All ?) have? Translate or localize or fixed?

mazzech commented 4 years ago

Oops... "localized" Screenshot 2020-04-11 at 10 26 51 of course:-)

mazzech commented 4 years ago

However, it works when looking at the frontend, taxonomy term is translated

Screenshot 2020-04-10 at 20 06 32 Screenshot 2020-04-10 at 20 06 27 Screenshot 2020-04-10 at 20 06 22

indigoxela commented 4 years ago

Tipp 1: compare that to a Drupal 7, if you find the time.

Tipp 2: selection should be properly filtered for vocabs with setting "translate".

mazzech commented 4 years ago

To be honest, all my D7 i18n projects used Entity Translation.

mazzech commented 4 years ago

Let's put it that way: what is the intended use case I should test or recreate?

indigoxela commented 4 years ago

all my D7 i18n projects used Entity Translation

Ah, OK, nontheless your testing is helpful here.

Regarding the autocomplete showing other languages - that's a bug in D7 also. Currently we're not trying yet to make i18n for Backdrop better than the D7 version. (We will though later on...).

what is the intended use case I should test or recreate?

I hoped, that you have some use-case in mind already. But you already wrote that you're not actually using i18n in D7. Hm... Then simply play around and see if you manage to get any php notice/warning/error.

mazzech commented 4 years ago

My use case IS that the do editors see the taxonomy terms in their language (node edit form). On the frontend, things seems to work pretty well:-)

indigoxela commented 4 years ago

My use case IS that the do editors see the taxonomy terms in their language (node edit form).

Yeah - which is a bug in D7 also. See my previous comment.

mazzech commented 4 years ago

Wait... I did use i18n a lot in D7, but with field translation (Entity Translation). But to be honest, I always had the "localize" requirement (one vocabulary for all languages, but with translated term name)

mazzech commented 4 years ago

OK, so using checkboxes instead of autocomplete would should work?

mazzech commented 4 years ago

Hmmmh, not really... Screenshot 2020-04-11 at 11 10 58

Oh, depends on language negotiation settings:-) Screenshot 2020-04-11 at 11 12 14

mazzech commented 4 years ago

Seems that I have to test with different users with different language settings.

indigoxela commented 4 years ago

@mazze: If in doubt, have a look at the D7 issues (only a subset...):

Please do not expect from me that I already fixed all the D7 issues. It took 50 commits to get the modules running on Backdrop without crashes and exceptions and errors :wink:

mazzech commented 4 years ago

@indigoxela no, I do not expect that at all, and believe me, I really appreciate your work, also because I know the complexity of i18n pretty well (including on other systems).

Let me do more test with different users (which is a more realistic scenario anyway;). I will come back to you soon:-)

indigoxela commented 4 years ago

...one vocabulary for all languages, but with translated term name

And you always used "localize" for that? Translate might have been the better option.

Let me do more test with different users ... more realistic scenario ...

Sure, you're welcome. And always inspect the dblog for php problems.

mazzech commented 4 years ago

"Translate" means different vocabulary structure per language, IMO. I really never had that requiremen. It always worked perfectly with "same structure, localized term names"

indigoxela commented 3 years ago

@mazzech I'm trying to clean up the i18n issue queue a bit. There hasn't been activity in this issue since April last year, so I think this one could get closed.

Feel free to reopen, if you still have questions or hints.