backdrop-contrib / i18n

Collection of modules to extend Backdrop CMS multilingual capabilities
https://backdropcms.org/project/i18n
GNU General Public License v2.0
2 stars 5 forks source link

View that lists localized terms #64

Closed laryn closed 2 years ago

laryn commented 3 years ago

I've run into a case where a view that displays localized taxonomy terms is showing them in the source language always. There is no option (for example) for adding the term name in localized format.

We can probably pluck out a handler or two from i18nviews and add it to the i18n_taxonomy module.

laryn commented 3 years ago

Possibilities:

indigoxela commented 3 years ago

Hey, @laryn you already gave porting a try.

How far did you get? Does i18nviews help with the exposed forms?

laryn commented 3 years ago

@indigoxela Yes, I have enabled the port on this dev site and both issues are resolved. I have linked my best guess as to which handlers are needed for each issue.

indigoxela commented 3 years ago

Hm, only the two linked files won't do the trick, it needs a lot more. Probably most files from the includes directory and then all autoload info and views_data_alter stuff.

This makes me think that this module might better stay its own project, i18n is already a hard to tame monster.

indigoxela commented 3 years ago

A quick hint re https://github.com/laryn/i18nviews/blob/343ea42c71bbeb2ea3db643ec9561a1b33c875ad/i18nviews.module#L30

That's $plugin = config_get('views.settings', 'views_localization_plugin');

indigoxela commented 3 years ago

Hm... there seems to be a bug in i18nviews filters. The filter shows localized terms, but doesn't filter correctly for them - nodes using a language neutral localized term do not appear in the result list. Could be my sloppy quick setup, though.

It feels a bit odd, to discuss this in the i18n queue, when I resist to include that module in the i18n project. :smile:

laryn commented 3 years ago

This makes me think that this module might better stay its own project, i18n is already a hard to tame monster.

Since views is in core, my thought was it should not require a separate download. If it can't easily be integrated directly into i18n how about bundling it as a submodule in i18n?

laryn commented 3 years ago

Hm... there seems to be a bug in i18nviews filters. The filter shows localized terms, but doesn't filter correctly for them - nodes using a language neutral localized term do not appear in the result list. Could be my sloppy quick setup, though.

Easily there could be bugs. This is a very quick port and I just tested for my immediate need so far...

indigoxela commented 3 years ago

If it can't easily be integrated directly into i18n how about bundling it as a submodule in i18n?

Not as long as I'm the only active maintainer. I spent way too many hours with i18n, and that's still ongoing. Why should I increase my pain. :grin:

laryn commented 3 years ago

Fair enough!

indigoxela commented 2 years ago

As this issue is mostly about the different i18nviews module, and there hasn't been activity for months, I'm closing this one (issue queue cleanup).

indigoxela commented 2 years ago

Reopening this, as it now turned out where the problem is: we missed this i18n issue and commit, which got merged in 2017.